Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build and push - part 1 #56

Open
wants to merge 97 commits into
base: unstable
Choose a base branch
from
Open

Conversation

magick93
Copy link

@magick93 magick93 commented Nov 27, 2024

Issue Addressed

  • Docker build and push only runs if tests and code quality passes
  • Removed step to create multi-arch docker manifest.
  • Added labels to the docker image, including git.revision - for provenance.

Which issue # does this PR address? See #28

NB: this is using the Hashicorp Vault Action to retrieve the docker username and key.

I'll followup in a less public forum regarding these details.

Follow-up tasks

  • Correctly configure HSC with correct details

  • Address the TODO in the make file

  • Need to get correct list of features.

hardcode docker repo, set dockerfile location
use Cargo.toml as source of truth
fix path for toml_reader.sh
Update Docker workflow to include architecture-specific tags and enab…
disable buildx imagetools, add labels
disable buildx imagetools, add labels
enable md book, only run on sipg org
linkchecker and fix yml formatting
Add release, debug, and code quality test jobs to Docker workflow
Only run docker build after passing tests
Remove redundant docker job
remove features from release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant