-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build and push - part 1 #56
Open
magick93
wants to merge
97
commits into
sigp:unstable
Choose a base branch
from
magick93:stable
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+643
−497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge test 1
branch check
tmp rm CROSS_FEATURES
use GH_TOKEN
hardcode docker repo, set dockerfile location
use correct dir
update rust and path
use Cargo.toml as source of truth
fix path for toml_reader.sh
debugging
try with TARGETPLATFORM arg
…le multiarch manifest creation
Update Docker workflow to include architecture-specific tags and enab…
disable buildx imagetools, add labels
disable buildx imagetools, add labels
enable md book, only run on sipg org
fix yml formatting
… for sigp organization
linkchecker and fix yml formatting
Add release, debug, and code quality test jobs to Docker workflow
Only run docker build after passing tests
Releases from docker
Remove redundant docker job
remove features
remove features from release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
git.revision
- for provenance.Which issue # does this PR address? See #28
NB: this is using the Hashicorp Vault Action to retrieve the docker username and key.
I'll followup in a less public forum regarding these details.
Follow-up tasks
Correctly configure HSC with correct details
Address the
TODO
in themake
fileNeed to get correct list of features.